From: Peter Cherriman Date: Wed, 23 Jul 2008 18:41:20 +0000 (+0100) Subject: increase buffer size for ID3 with images X-Git-Tag: v0.42~3 X-Git-Url: http://royale.zerezo.com/git/?p=FAPG;a=commitdiff_plain;h=0c1e07e01c487f248ed61fd22fd2a85be49eae19;hp=e7cff14b8d57de284b9dc9836b9c324580cac759 increase buffer size for ID3 with images > Peter Cherriman wrote: >> Here's the bug report.... >> >> FAPG outputs the following message: >> >> Warning >> ID3 header is huge (217974 bytes) ! trying anyway : >> /media/SANSA CLIP/GPODDER/scc18_final_kunle_olukotun.mp3 >> >> It then doesn't output a #EXTINF line for the file. Antoine Jacquet wrote: > I think there is a hard limit in FAPG on the number of bytes I read in > the file to avoid performance issues, so I think the ID3 artist/title > tag is after the image in your particular file, and this is why FAPG > never reaches it. Thanks for your advice. I fixed it by increasing the size of the "MAX" read size in bytes slightly from 200*1024 to 250*1024. The problem file I had a header of 217974 bytes. Signed-off-by: Antoine Jacquet --- diff --git a/fapg.c b/fapg.c index 38a27bf..17b02b8 100644 --- a/fapg.c +++ b/fapg.c @@ -43,7 +43,7 @@ #define MP3_BASE 1024 #define OGG_BASE 1024*10 -#define MAX 1024*200 /* 200ko for ID3 with JPEG images in it */ +#define MAX 1024*250 /* 250ko for ID3 with JPEG images in it */ #define FORMAT_M3U 0 #define FORMAT_PLS 1